Module talk:Rational: Difference between revisions
Jump to navigation
Jump to search
documentation |
No edit summary |
||
| Line 6: | Line 6: | ||
[[User:Sintel|Sintel]] ([[User talk:Sintel|talk]]) 20:34, 1 April 2024 (UTC) | [[User:Sintel|Sintel]] ([[User talk:Sintel|talk]]) 20:34, 1 April 2024 (UTC) | ||
== FJS implementation is indeed incorrect == | |||
128/127 should return a P1, not a d-2. [[User:FloraC|FloraC]] ([[User talk:FloraC|talk]]) 07:37, 4 September 2025 (UTC) | |||
Latest revision as of 07:37, 4 September 2025
Documentation
The function `converges` is rather opaque as to how it works, it should be rewritten or the algorithm should be properly documented.
The function `as_FJS` has a comment that says 'might be a bit incorrect', this doesn't give me much confidence that it's correct, someone who has intimate knowledge about FJS should confirm that it works as intended.
Sintel (talk) 20:34, 1 April 2024 (UTC)
FJS implementation is indeed incorrect
128/127 should return a P1, not a d-2. FloraC (talk) 07:37, 4 September 2025 (UTC)