Module talk:ET: Difference between revisions

(3 intermediate revisions by 3 users not shown)

Line 22:

</pre>

I had to undo a recent change (see above) since it was resulting in several templates breaking; specifically, the rat module was taking a very long time to calculate these large ratios and resulting in the interpreter terminating with signal 24. If these changes are necessary, might I suggest hardcoding them instead? [[User:Ganaram inukshuk|Ganaram inukshuk]] ([[User talk:Ganaram inukshuk|talk]]) 01:15, 22 January 2024 (UTC)

: I just did that change to ensure that the irrational numbers are fully accurate, so it's not necessary. I've put it down to 6 decimal digits now.

: [[User:CompactStar|CompactStar]] ([[User talk:CompactStar|talk]]) 01:52, 22 January 2024 (UTC)

:: Those aren't significantly more accurate than before. For pi its accuracy is actually worse. Definitely not worth the load time. Hardcoding is the way. [[User:FloraC|FloraC]] ([[User talk:FloraC|talk]]) 06:29, 22 January 2024 (UTC)

== Update ==

Using various approximations for pi etc. does not make any sense so they are commented out.

We should rewrite the math so the equave is not required to be a rational number, this restriction doesn't make sense anyway. I will take a look at how to clean up this mess soon.

: EDIT: I uncommented again since pages like [[9edϕ]] were broken.

[[User:Sintel|Sintel]] ([[User talk:Sintel|talk]]) 20:31, 1 April 2024 (UTC)

@@ Line 22: / Line 22: @@
 </pre>
 I had to undo a recent change (see above) since it was resulting in several templates breaking; specifically, the rat module was taking a very long time to calculate these large ratios and resulting in the interpreter terminating with signal 24. If these changes are necessary, might I suggest hardcoding them instead? [[User:Ganaram inukshuk|Ganaram inukshuk]] ([[User talk:Ganaram inukshuk|talk]]) 01:15, 22 January 2024 (UTC)
+: I just did that change to ensure that the irrational numbers are fully accurate, so it's not necessary. I've put it down to 6 decimal digits now.
+: [[User:CompactStar|CompactStar]] ([[User talk:CompactStar|talk]]) 01:52, 22 January 2024 (UTC)
+:: Those aren't significantly more accurate than before. For pi its accuracy is actually worse. Definitely not worth the load time. Hardcoding is the way. [[User:FloraC|FloraC]] ([[User talk:FloraC|talk]]) 06:29, 22 January 2024 (UTC)
+== Update ==
+Using various approximations for pi etc. does not make any sense so they are commented out.
+We should rewrite the math so the equave is not required to be a rational number, this restriction doesn't make sense anyway. I will take a look at how to clean up this mess soon.
+: EDIT: I uncommented again since pages like [[9edϕ]] were broken.
+[[User:Sintel|Sintel]] ([[User talk:Sintel|talk]]) 20:31, 1 April 2024 (UTC)