Module:Rational - Revision history

FloraC: Unify the format for S-expressions

2026-05-01T07:54:29Z

Unify the format for S-expressions

← Older revision		Revision as of 07:54, 1 May 2026
Line 174:		Line 174:
	end		end

	-- is it SkS(k+1) or Sk/S(k+1) or Sk^2S(k+1) or Sk*S(k+1)^2?		-- is it SkS(k + 1) or Sk/S(k + 1) or Sk^2S(k + 1) or Sk*S(k + 1)^2?
	for _, k in ipairs(superparticular_indices) do		for _, k in ipairs(superparticular_indices) do
	local r1 = superparticular_ratios[k]		local r1 = superparticular_ratios[k]
Line 180:		Line 180:
	if r1 and r2 then		if r1 and r2 then
	if p.eq(a, p.mul(r1, r2)) then		if p.eq(a, p.mul(r1, r2)) then
	table.insert(expressions, "S" .. k .. " ~~× S~~" .. (k + 1))		table.insert(expressions, "S" .. k .. "⋅S" .. (k + 1))
	end		end
	if p.eq(a, p.div(r1, r2)) then		if p.eq(a, p.div(r1, r2)) then
	table.insert(expressions, "S" .. k .. " / S" .. (k + 1))		table.insert(expressions, "S" .. k .. "/S" .. (k + 1))
	end		end
	if p.eq(a, p.mul(p.pow(r1, 2), r2)) then		if p.eq(a, p.mul(p.pow(r1, 2), r2)) then
	table.insert(expressions, "S" .. k .. "<sup>2</sup> ~~× S~~" .. (k + 1))		table.insert(expressions, "S" .. k .. "<sup>2</sup>⋅S" .. (k + 1))
	end		end
	if p.eq(a, p.mul(r1, p.pow(r2, 2))) then		if p.eq(a, p.mul(r1, p.pow(r2, 2))) then
	table.insert(expressions, "S" .. k .. " * S" .. (k + 1) .. "<sup>2</sup>")		table.insert(expressions, "S" .. k .. "⋅S" .. (k + 1) .. "<sup>2</sup>")
	end		end
	end		end
	end		end

	-- is it Sk/S(k+2)?		-- is it Sk/S(k + 2)?
	for _, k in ipairs(superparticular_indices) do		for _, k in ipairs(superparticular_indices) do
	local r1 = superparticular_ratios[k]		local r1 = superparticular_ratios[k]
Line 200:		Line 200:
	if r1 and r2 then		if r1 and r2 then
	if p.eq(a, p.div(r1, r2)) then		if p.eq(a, p.div(r1, r2)) then
	table.insert(expressions, "S" .. k .. " / S" .. (k + 2))		table.insert(expressions, "S" .. k .. "/S" .. (k + 2))
	end		end
	end		end
	end		end

	-- is it S(k-1)SkS(k+1)?		-- is it S(k - 1)SkS(k + 1)?
	for _, k in ipairs(superparticular_indices) do		for _, k in ipairs(superparticular_indices) do
	local r1 = superparticular_ratios[k - 1]		local r1 = superparticular_ratios[k - 1]
Line 212:		Line 212:
	if r1 and r2 and r3 then		if r1 and r2 and r3 then
	if p.eq(a, p.mul(r1, p.mul(r2, r3))) then		if p.eq(a, p.mul(r1, p.mul(r2, r3))) then
	table.insert(expressions, "S" .. (k - 1) .. " ~~× S~~" .. k .. " ~~× S~~" .. (k + 1))		table.insert(expressions, "S" .. (k - 1) .. "⋅S" .. k .. "⋅S" .. (k + 1))
	end		end
	end		end

FloraC: Todo

2025-09-04T07:41:03Z

Todo

← Older revision		Revision as of 07:41, 4 September 2025
Line 1,086:		Line 1,086:

	-- FJS representation of a rational number		-- FJS representation of a rational number
	-- ~~might be a bit~~ incorrect		-- NOTE: incorrect for prime 127 and possibly other rare cases
	-- TODO: ~~confirm correctness~~		-- TODO: identify the exact problem and fix it
	function p.as_FJS(a)		function p.as_FJS(a)
	if type(a) == "number" then		if type(a) == "number" then

ArrowHead294 at 13:18, 1 June 2025

2025-06-01T13:18:26Z

← Older revision		Revision as of 13:18, 1 June 2025
Line 1,535:		Line 1,535:
	function p.ket(frame)		function p.ket(frame)
	local unparsed = frame.args[1] or "1"		local unparsed = frame.args[1] or "1"
			local result = ""

	local a = p.parse(unparsed)		local a = p.parse(unparsed)
	if a == nil then		if a == nil then
	~~return~~ '~~<span style="color:red;">~~Invalid rational number: ' .. unparsed .. ".~~</span>~~"		result = '{{error\|Invalid rational number: ' .. unparsed .. ".}}"
			else
			result = p.as_ket(a, frame)
	end		end
	return ~~p.as_ket~~(~~a, frame~~)
			return frame:preprocess(result)
	end		end
	p.monzo = p.ket		p.monzo = p.ket

	return p		return p

ArrowHead294 at 18:18, 19 May 2025

2025-05-19T18:18:09Z

← Older revision		Revision as of 18:18, 19 May 2025
Line 1:		Line 1:
			local p = {}

	local seq = require("Module:Sequence")		local seq = require("Module:Sequence")
	local utils = require("Module:Utils")		local utils = require("Module:Utils")
	~~local p = {}~~

	-- enter a numerator n and denominator m		-- enter a numerator n and denominator m

FloraC: +is_prime

2025-04-01T14:12:05Z

+is_prime

@@ Line 661: / Line 661: @@
 	local den = p.mul(p.add(k, 1), p.sub(k, 1))
 	return p.eq(a, p.div(p.pow(k, 2), den))
 end
@@ Line 668: / Line 692: @@
 		a = p.new(a)
 	end
-	if a.nan or a.inf or a.zero then
-		return false
+	-- nan, inf, zero, and negative numbers are not highly composite
-	end
+	if a.nan or a.inf or a.zero or a.sign == -1 then
 		return false
 	end
 	-- non-integers are not highly composite
 	for factor, power in pairs(a) do
@@ Line 683: / Line 706: @@
 		end
 	end
 	local last_power = 1 / 0
 	local max_prime = p.max_prime(a)

FloraC: Request precise description

2025-03-05T14:11:01Z

Request precise description

← Older revision		Revision as of 14:11, 5 March 2025
Line 332:		Line 332:

	-- compute a canonical representation of `a` modulo powers of `b`		-- compute a canonical representation of `a` modulo powers of `b`
			-- TODO: describe the exact behavior
			-- it seems bugged when the equave is a fraction
	function p.modulo_mul(a, b)		function p.modulo_mul(a, b)
	if type(a) == "number" then		if type(a) == "number" then

Ganaram inukshuk: added is_within_int_limit function, because there were enough use-cases to add it

2024-12-21T22:32:29Z

added is_within_int_limit function, because there were enough use-cases to add it

@@ Line 869: / Line 869: @@
 end
--- find max prime involved in the factorisation
+-- Check if ratio is within an int limit; that is, neither its numerator nor
--- (a.k.a. prime limit or harmonic class) of a rational number
+-- denominator exceed that limit.
-function p.max_prime(a)
+function p.is_within_int_limit(a, lim)
-	if type(a) == "number" then
+	return p.int_limit(a) <= lim
 end
@@ Line 918: / Line 904: @@
 	local num, den = p.as_pair(a_copy)
 	return math.max(num, den)
 end

Ganaram inukshuk: Add int limit function (prepwork for a separate algorithm)

2024-09-22T03:42:10Z

Add int limit function (prepwork for a separate algorithm)

@@ Line 887: / Line 887: @@
 	end
 	return max_factor
 end

FloraC: Oops

2024-08-10T14:03:01Z

Oops

← Older revision		Revision as of 14:03, 10 August 2024
Line 589:		Line 589:
	if factor == 2 and reduced then		if factor == 2 and reduced then
	-- pass (ignore factors of 2 for reduced subharmonic check)		-- pass (ignore factors of 2 for reduced subharmonic check)
	elseif power < 0 then		elseif power > 0 then
	return false		return false
	end		end

FloraC: This used to work. Restore the old code with better documentation

2024-08-10T13:38:01Z

This used to work. Restore the old code with better documentation

← Older revision		Revision as of 13:38, 10 August 2024
Line 552:		Line 552:
	end		end

	-- determine whether a rational number represents a harmonic		-- determine whether a rational number represents a harmonic.
	-- ~~TODO~~: ~~rework. doesn't correctly~~ check reduced ~~harmonics~~.		-- reduced: check for reduced harmonic instead.
	function p.is_harmonic(a, reduced, large)		function p.is_harmonic(a, reduced, large)
	if type(a) == "number" then		if type(a) == "number" then
Line 563:		Line 563:
	for factor, power in pairs(a) do		for factor, power in pairs(a) do
	if type(factor) == "number" then		if type(factor) == "number" then
	if power < 0 then		if factor == 2 and reduced then
			-- pass (ignore factors of 2 for reduced harmonic check)
			elseif power < 0 then
	return false		return false
	end		end
	end		end
	end		end
	if reduced then ~~-- for reduced harmonics, a false will have been returned before reaching here~~		if reduced then
	return p.is_reduced(a, 2, large)		return p.is_reduced(a, 2, large)
	end		end
Line 574:		Line 576:
	end		end

	-- determine whether a rational number represents a subharmonic		-- determine whether a rational number represents a subharmonic.
	-- ~~TODO~~: ~~rework. doesn't correctly~~ check reduced ~~subharmonics~~.		-- reduced: check for reduced subharmonic instead.
	function p.is_subharmonic(a, reduced, large)		function p.is_subharmonic(a, reduced, large)
	if type(a) == "number" then		if type(a) == "number" then
Line 585:		Line 587:
	for factor, power in pairs(a) do		for factor, power in pairs(a) do
	if type(factor) == "number" then		if type(factor) == "number" then
	if power > 0 then		if factor == 2 and reduced then
			-- pass (ignore factors of 2 for reduced subharmonic check)
			elseif power < 0 then
	return false		return false
	end		end
	end		end
	end		end
	if reduced then ~~-- for reduced subharmonics, a false will have been returned before reaching here~~		if reduced then
	return p.is_reduced(a, 2, large)		return p.is_reduced(a, 2, large)
	end		end